sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api, plc4j-core, dummy-driver URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833605
########## File path: plc4j/utils/raw-sockets/src/main/java/org/apache/plc4x/java/utils/rawsockets/RawSocket.java ########## @@ -35,7 +25,39 @@ import java.util.LinkedList; import java.util.List; import java.util.Map; -import java.util.concurrent.*; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; + +import org.apache.commons.lang3.SystemUtils; +import org.pcap4j.core.BpfProgram; +import org.pcap4j.core.NotOpenException; +import org.pcap4j.core.PacketListener; +import org.pcap4j.core.PcapAddress; +import org.pcap4j.core.PcapHandle; +import org.pcap4j.core.PcapNativeException; +import org.pcap4j.core.PcapNetworkInterface; +import org.pcap4j.core.Pcaps; +import org.pcap4j.packet.AbstractPacket; +import org.pcap4j.packet.ArpPacket; +import org.pcap4j.packet.EthernetPacket; +import org.pcap4j.packet.IpV4Packet; +import org.pcap4j.packet.IpV4Rfc791Tos; +import org.pcap4j.packet.Packet; +import org.pcap4j.packet.UnknownPacket; +import org.pcap4j.packet.namednumber.ArpHardwareType; +import org.pcap4j.packet.namednumber.ArpOperation; +import org.pcap4j.packet.namednumber.EtherType; +import org.pcap4j.packet.namednumber.IpNumber; +import org.pcap4j.packet.namednumber.IpVersion; +import org.pcap4j.util.ByteArrays; +import org.pcap4j.util.LinkLayerAddress; +import org.pcap4j.util.MacAddress; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; Review comment: import reordering see other comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
