sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api, plc4j-core, dummy-driver URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170831995
########## File path: examples/dummy-driver/src/main/java/org/apache/plc4x/java/examples/dummydriver/netty/DummyProtocol.java ########## @@ -18,26 +18,27 @@ Licensed to the Apache Software Foundation (ASF) under one */ package org.apache.plc4x.java.examples.dummydriver.netty; -import io.netty.buffer.ByteBuf; -import io.netty.buffer.ByteBufUtil; -import io.netty.buffer.Unpooled; -import io.netty.channel.ChannelHandlerContext; -import io.netty.handler.codec.MessageToMessageCodec; +import java.util.List; + import org.apache.plc4x.java.api.messages.PlcReadRequest; import org.apache.plc4x.java.api.messages.PlcRequest; import org.apache.plc4x.java.api.messages.PlcRequestContainer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.List; +import io.netty.buffer.ByteBuf; +import io.netty.buffer.ByteBufUtil; +import io.netty.buffer.Unpooled; +import io.netty.channel.ChannelHandlerContext; +import io.netty.handler.codec.MessageToMessageCodec; Review comment: we should look into why eclipse does sort the imports other than idea. We have a [.editorconfig](http://editorconfig.org/) (which eclipse doesn't do out-of-box and needs the plugin installed) but I don't think it respects import order. Without a unified import order we mess up our diff from time to time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
