JulianFeinauer commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207198839
##########
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
##########
@@ -58,7 +58,12 @@ public void setUp() {
@After
public void tearDown() {
if(s7PlcConnection.isConnected()) {
- s7PlcConnection.close();
+ try {
+ s7PlcConnection.close();
+ } catch (NullPointerException e) {
Review comment:
Yes, this is the code i refactored. Reason for the BlockingException is,
that Netty does not allow the "await" call in a lambda which is excuted on its
thread pool.
Thus, I changed program flow to avoid this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
