JulianFeinauer commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207198177
##########
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
##########
@@ -58,7 +58,12 @@ public void setUp() {
@After
public void tearDown() {
if(s7PlcConnection.isConnected()) {
- s7PlcConnection.close();
+ try {
+ s7PlcConnection.close();
+ } catch (NullPointerException e) {
Review comment:
I added a fix for that.
Before catching the NPE an NPE was raised (trace from previous build:
java.lang.NullPointerException
at
org.apache.plc4x.java.s7.connection.S7PlcConnectionIT.tearDown(S7PlcConnectionIT.java:61))
Now as the NPE is catched a BlockingOperationException is thrown... weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
