Hi Etienne,

I think Otto is right. 

You start off the tutorial by building a driver for the 
<protocolName>Brol</protocolName>
Then your mspec module provides "eip"
public String getProtocolCode() {
        return "eip";
    }

So in theory the code generator will be looking for a "Brol" module and all it 
has is a "eip" module.

Chris



Am 18.03.20, 15:00 schrieb "Etienne Robinet" <[email protected]>:

    Hi Chris,
    so you think of starting with the MSPEC, then the Configuration & the 
Driver to end with the Logic?
    Of course you can convert it to publish it! :)
    
    @Otto what do you mean? I took example on the EIP to show how it could look 
like because the code depends on the protocol you're implementign.
    
    Regards,
    
    Etienne
    
    On 2020/03/18 12:57:18, Christofer Dutz <[email protected]> wrote: 
    > Hi Etienne,
    > 
    > I guess all we are missing is that we get notice from secretary@ that 
your ICLA is on file as the whole contribution is well above the "minor 
contribution" threshold ;-)
    > 
    > Regarding your documentation. It looks really good ... the only thing I 
would probably suggest to change (if you agree), would be to start with the 
mspec and then go to creating a driver. This way around you're sort of building 
the roof for a house that's not there yet. I could imagine that starting the 
other way around you always have something you can build. But all in all ... 
great job. It's highly appreciated. We would however convert that to asciidoc 
and integrate that into the website, if you allow us to.
    > 
    > Chris
    > 
    > 
    > 
    > Am 18.03.20, 12:20 schrieb "Etienne Robinet" <[email protected]>:
    > 
    >     Hi all,
    >     I finished the EipFieldHandler with the basic types, and also the 
document I talked about yesterday.
    >     You can have a look here as it is on my branch. 
    >     
https://github.com/etiennerobinet/plc4x/blob/develop/Writing%20generated%20Driver.md
    >     
    >     What do we need more now to merge this to the dev branch?
    >     
    >     Etienne
    >     
    >     
    >     On 2020/03/17 15:07:16, Christofer Dutz <[email protected]> 
wrote: 
    >     > That's more than we could ask for and very happy you're doing it.
    >     > 
    >     > Your contribution is extremely appreciated.
    >     > 
    >     > Chris
    >     
    >     
    >     
    > 
    > 
    

Reply via email to