Hi Etienne,
I guess all we are missing is that we get notice from secretary@ that your ICLA
is on file as the whole contribution is well above the "minor contribution"
threshold ;-)
Regarding your documentation. It looks really good ... the only thing I would
probably suggest to change (if you agree), would be to start with the mspec and
then go to creating a driver. This way around you're sort of building the roof
for a house that's not there yet. I could imagine that starting the other way
around you always have something you can build. But all in all ... great job.
It's highly appreciated. We would however convert that to asciidoc and
integrate that into the website, if you allow us to.
Chris
Am 18.03.20, 12:20 schrieb "Etienne Robinet" <43...@etu.he2b.be>:
Hi all,
I finished the EipFieldHandler with the basic types, and also the document
I talked about yesterday.
You can have a look here as it is on my branch.
https://github.com/etiennerobinet/plc4x/blob/develop/Writing%20generated%20Driver.md
What do we need more now to merge this to the dev branch?
Etienne
On 2020/03/17 15:07:16, Christofer Dutz <christofer.d...@c-ware.de> wrote:
> That's more than we could ask for and very happy you're doing it.
>
> Your contribution is extremely appreciated.
>
> Chris
