chrisdutz commented on code in PR #962:
URL: https://github.com/apache/plc4x/pull/962#discussion_r1207998579
##########
plc4j/drivers/opcua/src/test/java/org/apache/plc4x/java/opcua/OpcuaPlcDriverTest.java:
##########
Review Comment:
Please don't just disable tests without opening a new issue for it ... this
way we have already disabled very many tests, tests we don't know about or
forget.
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/values/PlcValueHandler.java:
##########
@@ -83,6 +83,9 @@ public static PlcValue of(Object[] values) {
if (value instanceof Long) {
return PlcLINT.of(value);
}
+ if (value instanceof BigInteger) {
+ return PlcDINT.of(value);
Review Comment:
Woudln't a LINT be the better match, as a BigInteger could actually be even
bigger than the DINT value space?
##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaProtocolLogic.java:
##########
@@ -195,7 +195,7 @@ public CompletableFuture<PlcReadResponse>
read(PlcReadRequest readRequest) {
future.complete(new DefaultPlcReadResponse(request,
status));
return;
}
- } catch (ParseException e) {
+ } catch (Exception e) {
Review Comment:
What was the reasoning behind this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
