PatrykGala commented on code in PR #962:
URL: https://github.com/apache/plc4x/pull/962#discussion_r1208525245
##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaProtocolLogic.java:
##########
@@ -195,7 +195,7 @@ public CompletableFuture<PlcReadResponse>
read(PlcReadRequest readRequest) {
future.complete(new DefaultPlcReadResponse(request,
status));
return;
}
- } catch (ParseException e) {
+ } catch (Exception e) {
Review Comment:
The uncaught PlcUnsupportedDataTypeException from PlcValueHandler caused the
CompletableFuture not to complete, and the thread is hanging on
CompletableFuture.get().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
