GitHub user hutcheb added a comment to the discussion: [DISCUSS] Increase the rules for builds?
I absolutely agree that something needs to be done to improve the quality of code being committed to the develop branch. We have everything in place to do this with the PR function. This runs the CI process (Which we can add whatever checks we feel appropriate) for each language and if it doesn't build then it shouldn't be merged into develop. This may also increase participation in the project as picking a random person to review it may be just enough encouragement to get someone involved. I also believe people will be able to learn a lot just by reviewing and commenting on other peoples contributions. In saying this, I'd probably hold off on enforcing not committing directly to the develop branch, or having a requirement for at least one review. But I think it would be a good starting point to move forward. On Cesar's concern that it will stall development, I have the same concern. I think it is un-reasonable for people to contribute to other languages if the either aren't interested, don't have the time or just aren't able to because they aren't used to the language. I would be in favor to start using the versioning function of mspec files more, and then tackling versioning issues later on. GitHub link: https://github.com/apache/plc4x/discussions/997#discussioncomment-6193168 ---- This is an automatically sent email for dev@plc4x.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@plc4x.apache.org
