chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376205948
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java:
##########
@@ -111,7 +112,7 @@ public Plc4xProtocolBase<BASE_PACKET_CLASS>
configurePipeline(Configuration conf
if (driverContextClass != null) {
protocol.setDriverContext(configure(configuration,
createInstance(driverContextClass)));
}
- Plc4xNettyWrapper<BASE_PACKET_CLASS> context = new
Plc4xNettyWrapper<>(configuration.getTimeoutManager(), pipeline, passive,
protocol,
+ Plc4xNettyWrapper<BASE_PACKET_CLASS> context = new
Plc4xNettyWrapper<>(new NettyHashTimerTimeoutManager(), pipeline, passive,
protocol,
Review Comment:
This was simply me cleaning up something that I thought didn't belong into
the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]