chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376216805
##########
plc4j/transports/pcap-shared/src/main/java/org/apache/plc4x/java/transport/pcap/PcapTransportConfiguration.java:
##########
@@ -19,22 +19,18 @@
package org.apache.plc4x.java.transport.pcap;
import org.apache.plc4x.java.spi.transport.TransportConfiguration;
-import org.apache.plc4x.java.utils.pcap.netty.config.PcapChannelConfig;
import org.apache.plc4x.java.utils.pcap.netty.handlers.PacketHandler;
public interface PcapTransportConfiguration extends TransportConfiguration {
+ int NO_DEFAULT_PORT = -1;
- default boolean getSupportVlans() {
- return false;
- }
+ boolean getSupportVlans();
default int getDefaultPort() {
- return PcapChannelConfig.ALL_PORTS;
+ return NO_DEFAULT_PORT;
Review Comment:
Well ... this way it matches the constant where it's used in
RawSocketTransport.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
