chrisdutz commented on code in PR #1376:
URL: https://github.com/apache/plc4x/pull/1376#discussion_r1477776224
##########
protocols/knxnetip/src/main/resources/protocols/knxnetip/knxnetip.mspec:
##########
@@ -882,9 +882,9 @@
[reserved uint 4 '0x00']
[simple uint 4 month]
[reserved uint 3 '0x00']
- [simple uint 5 dayofmonth]
+ [simple uint 5 dayOfMonth]
Review Comment:
Ooooh ... jesus ... I think in the type PDT_DATE_TIME something really
creapy is going on ... I see day of week sort of spanning across two bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
