splatch commented on code in PR #1376:
URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478031568
##########
plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java:
##########
@@ -71,12 +71,22 @@ public void onConnect(ConversationContext<FirmataMessage>
context) {
LOGGER.debug("Sending Firmata Reset Command");
FirmataMessageCommand resetCommandMessage = new
FirmataMessageCommand(new FirmataCommandSystemReset());
context.sendRequest(resetCommandMessage)
+ .onTimeout(e -> {
+ LOGGER.info("Timeout during Connection establishment, closing
channel...");
Review Comment:
The `onTimeout` is not propagated well across stack, from what I remember in
the past `onTimeout` had to specified at first, otherwise it was
ignored/swallowed by lower part of engine. Not sure if that's true nowadays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
