> > > > It's ok, but not nice to have the bin directory in the src dist > duplicated in (/bin, /src/shell) - we can change that on the next release. > I still think it's better to have the shell scripts not under /bin in the > source tree. > > +1 >
I agree, I didn't like it in /bin, but that's where it has been historically for this project, and it was noted as missing when it moved to /src/shell, so I put it back in the build. In the next version we can make that a prominent "feature" noted in the release docs and move it from /bin. Probably not used very often these days anyway. > > I don't like to have the javadocs in the src dist, but rather would like > to see them in bin dist. > > +1 > They are in the bin dist as a JAR file. Again these were noted as missing from the src package, so I put them in. I don't have a strong opinion either way. I don't generally use them directly, relying on IDE integrations to display relevant docs. > > > > In my view, the src dist is a copy of the trunk whereas the bin dist > contains all the compiled/generated artifacts. > > +1 > Makes sense. This particular project appears to have been a bit muddied in it's far distant past in that regard. > > > > The pgp signature (*.asc) doesn't need to be check-summed - for Nexus, > I'm not sure if they are automatically created on uploading the signature > files. > > +1, it doesn’t serve any purpose I’ve only ever seen it on a single > project in the incubator and at least on Apache dist they should be removed. > I agree. I have no explanation or excuse for why I did that. Probably a misreading of something as I attempted to build release instructions from scratch and crib much of the info from the POI release-guide.txt. Will remove them before moving to the release folder. > > > - the KEYS file: I'd like to have one merged KEYS file for both projects > and use svn externals to link to the one place. > > Since they are both in the same dist area in on Apache then they must be > merged or the main one has all the keys. > > There is one place on dist and never inside a release. > Yes, Dominik and I have corresponded over that a bit, as his key in production was out of date or listed twice, depending on the file. Something to do for the next release for sure. Greg
