netmackan opened a new pull request #182: URL: https://github.com/apache/poi/pull/182
Before this patch the POIFSMiniStore.syncWithDataStore() method sets the root property size to be based on the number of sectors in each block that is used. However it can happen is some files that a block is not only filled in the beginning. Instead there could be gaps with unused sectors within it and currently POI does not count those. However the MS tool (in this case signtool) calculates the occupied size (i.e. the size from beginning of block up to and including the last used sector). Specifically for Windows Installer (MSI) files, if the root size is not calculated this way the digital signature will not show up as correct. This pull request changes the calculation of the root property so that Windows will not complain also for files with blocks that has unused sectors in the middle. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
