netmackan commented on pull request #182: URL: https://github.com/apache/poi/pull/182#issuecomment-641781168
Hi @pjfanning, Unfortunately, I do not own the test file so I can not share it. But I will try to create a new one and get back as soon as I get time. The file (MSI/Windows Installer) was created with MS Visual Studio 2017 15.9 and it happened that only some of the created files would have a fragmented block and trigger the issue. Regarding the scenario, my thought on why this has not been seen before is probably because in most scenarios it is not important that the root property has the right size. For the MSI use case probably Windows is more strict in verifying things as part of the digital signature verification. On top of that this only happens when the file added to the POIFS is larger then 4096 bytes (i.e. not a small block) and only when the original file happens to have a block that is having gaps in it so that the size calculation will be different than the current implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
