xzel23 commented on code in PR #590:
URL: https://github.com/apache/poi/pull/590#discussion_r1492235388
##########
poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java:
##########
@@ -541,12 +540,11 @@ public ConditionalFormattingTable
getConditionalFormattingTable() {
public void setDimensions(int firstrow, short firstcol, int lastrow, short
lastcol)
{
LOGGER.atDebug().log("Sheet.setDimensions");
- LOGGER.atDebug().log(() -> new SimpleMessage(
Review Comment:
Correct. And while we are at it: since we are at Log4J2 now, I think we
should instead better use something like this:
```
LOGGER.debug("Sheet.setDimensions");
LOGGER.debug("firstrow{}firstcol{}lastrow{}lastcol{}", firstrow,
firstcol, lastrow, lastcol);
```
So, get rid of the `atDebug()`where not necessary and use the MessageFormat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
