pjfanning commented on code in PR #590:
URL: https://github.com/apache/poi/pull/590#discussion_r1492258847
##########
poi/src/main/java/org/apache/poi/hssf/model/InternalSheet.java:
##########
@@ -541,12 +540,11 @@ public ConditionalFormattingTable
getConditionalFormattingTable() {
public void setDimensions(int firstrow, short firstcol, int lastrow, short
lastcol)
{
LOGGER.atDebug().log("Sheet.setDimensions");
- LOGGER.atDebug().log(() -> new SimpleMessage(
Review Comment:
if we do change this line, I suggest that we improve the format of its
output - eg
```
LOGGER.debug("firstrow: {} firstcol: {} lastrow: {} lastcol: {}", firstrow,
firstcol, lastrow, lastcol);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
