[ 
https://issues.apache.org/jira/browse/PIO-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446245#comment-15446245
 ] 

Marcin Ziemiński commented on PIO-28:
-------------------------------------

The current refactoring is just about detaching some logic from side effects. 
The functions I moved to the command sub package could be used in some decisive 
parts of architecture you described as well. Currently CLI is simply printing 
some output on console from results produced by functions responsible for logic.

I like the idea of micro services, however it seems like a lot more work and 
planning to do. I would be willing to devote some of my time to that, but I 
think that for now getting some simple admin server to control remote machine 
is a good first step and can give us something functional faster. 

> Extract logic from functions handling console commands in tools package.
> ------------------------------------------------------------------------
>
>                 Key: PIO-28
>                 URL: https://issues.apache.org/jira/browse/PIO-28
>             Project: PredictionIO
>          Issue Type: Sub-task
>            Reporter: Marcin Ziemiński
>            Priority: Minor
>
> Currently functions used by Console.scala to handle commands are evaluated 
> for side effects - printing logs to the user. They either return integers or 
> units and sometimes use sys.exit(1) on failure.
> The actual logic should be extracted from them to some other place for future 
> applications, e.g. to be used by admin server, which is not implemented yet.
> Reporting results to the client should be separated from processing 
> application logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to