[
https://issues.apache.org/jira/browse/PIO-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517543#comment-15517543
]
ASF GitHub Bot commented on PIO-28:
-----------------------------------
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/283
This looks good to me, but due to the size of this PR, it would be nice to
have extra pairs of eyes. Could @pferrel / @EmergentOrder help? This PR would
be the first step to making admin API possible.
> Extract logic from functions handling console commands in tools package.
> ------------------------------------------------------------------------
>
> Key: PIO-28
> URL: https://issues.apache.org/jira/browse/PIO-28
> Project: PredictionIO
> Issue Type: Sub-task
> Reporter: Marcin Ziemiński
> Priority: Minor
>
> Currently functions used by Console.scala to handle commands are evaluated
> for side effects - printing logs to the user. They either return integers or
> units and sometimes use sys.exit(1) on failure.
> The actual logic should be extracted from them to some other place for future
> applications, e.g. to be used by admin server, which is not implemented yet.
> Reporting results to the client should be separated from processing
> application logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
