[ 
https://issues.apache.org/jira/browse/PIO-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833201#comment-15833201
 ] 

Chan commented on PIO-51:
-------------------------

I'm not sure I understand. I feel like a lot of this is based on the assumption 
that metadata registry (on a future agenda) is already built. This is just a 
small incremental step, not aimed to change the workflow in any way, but to 
make the "engineVersion" more explicit and flexible. 

First I want to clarify the terms. As of now, there are "engineId", 
"engineVersion", and "engineInstanceId" that have independent roles in the 
workflow. "EngineId" is a variant Id, something like 
"org.template.recommendation.RecommendationEngine". "EngineVersion" is the 
filepath hash. PIO uses these two fields to look for the latest trained model 
when deploying. "EngineInstanceId" directly refers to the trained model, and is 
only created after `pio train`.

To be clear, this ticket is not aimed at changing the workflow. It just adds an 
option to run pio commands outside of engine directory with a CLI argument. 
Thus, it wouldn't break any code that works currently with PIO.

The changes can be viewed here: 
https://github.com/apache/incubator-predictionio/pull/328/commits/e2d6f7e7ff9cb782d3365e5a508a3e8c111366f5


> Enable `pio build/train/deploy` outside of engine directory
> -----------------------------------------------------------
>
>                 Key: PIO-51
>                 URL: https://issues.apache.org/jira/browse/PIO-51
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Chan
>
> Users can now provide the engine directory path as —engine-dir or -ed, and 
> call `pio build/train/deploy` from anywhere.
> The “engineVersion” used to identify a prediction engine is created using the 
> hash of the engine directory path. As a result, the filepath of the engine 
> had to be kept the same in a distributed setup, with multiple machines using 
> the same trained model. This was a point of confusion for some users, which 
> led to this change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to