[
https://issues.apache.org/jira/browse/PIO-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902467#comment-15902467
]
ASF GitHub Bot commented on PIO-51:
-----------------------------------
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/357#discussion_r105085253
--- Diff:
tools/src/main/scala/org/apache/predictionio/tools/console/Console.scala ---
@@ -734,7 +734,7 @@ object Console extends Logging {
}
}
- def getEngineInfo(jsonFile: File): EngineInfo = {
+ def getEngineInfo(jsonFile: File, engineDir: Option[String]): EngineInfo
= {
--- End diff --
@chanlee514 should we just pass in a `String` here? It doesn't look like
there would be a case for `None`. It also looks like
`o.a.p.tools.Common.getEngineDirPath` has already taken care of getting the
current working directory, so I think it should be safe to just drop using
`user.dir` completely.
> Enable `pio build/train/deploy` outside of engine directory
> -----------------------------------------------------------
>
> Key: PIO-51
> URL: https://issues.apache.org/jira/browse/PIO-51
> Project: PredictionIO
> Issue Type: Improvement
> Reporter: Chan
> Assignee: Chan
> Fix For: 0.11.0
>
>
> Users can now provide the engine directory path as —engine-dir or -ed, and
> call `pio build/train/deploy` from anywhere.
> The “engineVersion” used to identify a prediction engine is created using the
> hash of the engine directory path. As a result, the filepath of the engine
> had to be kept the same in a distributed setup, with multiple machines using
> the same trained model. This was a point of confusion for some users, which
> led to this change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
