+1 (non-binding)
On Thu, Feb 16, 2023 at 11:11 AM Jiuming Tao <jm...@streamnative.io.invalid> wrote: > > I’ve added the `Compatibility` selection into the PIP, please help review > and vote the PIP > > Thanks, > Tao Jiuming > > > > > 2023年2月15日 14:58，Zike Yang <z...@apache.org> 写道： > > > > Hi, Jiuming > > > >> bump > > > > As for the discussion here[0], could you add a `Compatibility` section > > to talk about compatibility in more detail? WDYT? > > Then we could start the vote again. > > > > [0] https://lists.apache.org/thread/2bjg39zh7z38bzbnqngbo5l4jzkjttrq > > > > Thanks, > > Zike Yang > > > > On Wed, Feb 15, 2023 at 1:34 PM Tao Jiuming <dao...@apache.org> wrote: > >> > >> > >> bump > >> > >> On 2023/02/13 06:56:09 Jiuming Tao wrote: > >>> Hi all, > >>> > >>> I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > >>> > >>> Motivation: > >>> > >>> There are two types of subscriptions for a topic: Durable and > Non-durable. > >>> > >>> We create a Consumer with a Durable subscription and a Reader with a > Non-durable subscription. > >>> > >>> But for NonPersistentTopic, creating a Durable subscription is > meaningless, NonPersistentSubscription doesn't have a ManagedCursor to > persistent its data. After its consumer disconnected, the subscription > couldn't be removed automatically if we didn't set the value of > subscriptionExpirationTimeMinutes greater than 0. > >>> > >>> For subscriptionExpirationTimeMinutes, it controls the subscription > expiration of NonPersistentTopic and PersistentTopic, if we set the value > of subscriptionExpirationTimeMinutes greater than 0, it may lead to data > loss(The durable subscriptions of PersistentTopic also can be removed). > >>> > >>> And the Non-durable subscriptions will be removed automatically after > all the consumers disconnected, it's the existing logic. > >>> > >>> For the purpose of removing the subscriptions which have no active > consumers of NonPersistentTopic and the above reasons, we can make all the > subscriptions of a NonPersistentTopic Non-durable. > >>> > >>> > >>> > >>> For more details, you can read: > https://github.com/apache/pulsar/issues/19448 < > https://github.com/apache/pulsar/issues/19448> > >>> > >>> And the discuss thread is available at: > https://lists.apache.org/thread/2ltmyglnb25jy8nk58twkwbglws43bst < > https://lists.apache.org/thread/2ltmyglnb25jy8nk58twkwbglws43bst> > >>> > >>> Thanks, > >>> Tao Jiuming > >
