Hi, tison. Thanks for your feedback. I noticed that the master branch also doesn't have NOTICE files. I'll add it first and then launch release 1.8.2-rc.3
Thanks, Baodi Shi On Apr 12, 2023 at 10:14:20, tison <wander4...@gmail.com> wrote: > Thank you! I can successfully run the example. > > However, -1 because the source release doesn't contain a NOTICE file. > > Other check items including LICENSE, license headers, checksum and GPG sign > should be fine. > > Best, > tison. > > > Baodi Shi <ba...@apache.org> 于2023年4月12日周三 09:48写道： > > This example connects test env. Maybe it's network latency or server > > instability. > > > You can try again. > > > BTW: The token expires in tls-token.js . I updated it, you can pull the > > main branch and try it. > > > Thanks, > > Baodi Shi > > > > On Apr 12, 2023 at 00:22:53, Zili Chen <ti...@apache.org> wrote: > > > > Hi Baodi, > > > > > > When running the tls test you provided, I encountered this error: > > > > > > $ node tls-oauth2.js > > > > > > [INFO][ClientConnection:190] [<none> -> pulsar+ssl:// > > > > > > baodi-test-7407d844-b456-49e1-987c-24f1a5c162cb.usce1-whale.test.g.sn2.dev:6651 > > ] > > > Create ClientConnection, timeout=10000 > > > [INFO][ConnectionPool:97] Created connection for pulsar+ssl:// > > > > > > baodi-test-7407d844-b456-49e1-987c-24f1a5c162cb.usce1-whale.test.g.sn2.dev:6651 > > > [INFO][ClientConnection:388] [198.18.0.6:63458 -> 198.19.146.80:6651] > > > Connected to broker > > > [ERROR][ClientConnection:488] [198.18.0.6:63458 -> 198.19.146.80:6651] > > > Handshake failed: stream truncated > > > [INFO][ClientConnection:1600] [198.18.0.6:63458 -> 198.19.146.80:6651] > > > Connection closed with ConnectError > > > [ERROR][ClientImpl:184] Error Checking/Getting Partition Metadata while > > > creating producer on persistent://public/default/test-tls100000 -- > > > ConnectError > > > [INFO][ClientConnection:269] [198.18.0.6:63458 -> 198.19.146.80:6651] > > > Destroyed connection > > > node:internal/process/promises:289 > > > triggerUncaughtException(err, true /* fromPromise */); > > > ^ > > > > > > [Error: Failed to create producer: ConnectError] > > > > > > Node.js v19.8.1 > > > > > > $ node tls-token.js > > > > > > [INFO][ClientConnection:190] [<none> -> pulsar+ssl:// > > > > > > baodi-test-7407d844-b456-49e1-987c-24f1a5c162cb.usce1-whale.test.g.sn2.dev:6651 > > ] > > > Create ClientConnection, timeout=10000 > > > [INFO][ConnectionPool:97] Created connection for pulsar+ssl:// > > > > > > baodi-test-7407d844-b456-49e1-987c-24f1a5c162cb.usce1-whale.test.g.sn2.dev:6651 > > > [INFO][ClientConnection:388] [198.18.0.6:63459 -> 198.19.146.80:6651] > > > Connected to broker > > > [ERROR][ClientConnection:488] [198.18.0.6:63459 -> 198.19.146.80:6651] > > > Handshake failed: stream truncated > > > [INFO][ClientConnection:1600] [198.18.0.6:63459 -> 198.19.146.80:6651] > > > Connection closed with ConnectError > > > [ERROR][ClientImpl:184] Error Checking/Getting Partition Metadata while > > > creating producer on persistent://public/default/test-tls100000 -- > > > ConnectError > > > [INFO][ClientConnection:269] [198.18.0.6:63459 -> 198.19.146.80:6651] > > > Destroyed connection > > > node:internal/process/promises:289 > > > triggerUncaughtException(err, true /* fromPromise */); > > > ^ > > > > > > [Error: Failed to create producer: ConnectError] > > > > > > Node.js v19.8.1 > > > > > > I don't know if it's because the Pulsar URL isn't public or other issues. > > > > > > Best, > > > tison. > > > > > > On 2023/04/11 15:21:37 Baodi Shi wrote: > > > > > > Hi everyone, > > > > > > > > > This is the first release candidate for Apache Pulsar Node.js client, > > > > > > version 1.8.2. > > > > > > > > > It fixes the following issues: > > > > > > > > > > > > https://github.com/apache/pulsar-client-node/pulls?q=is%3Apr+label%3Arelease%2Fv1.8.2+is%3Aclosed > > > > > > > > > Please download the source files and review this release candidate: > > > > > > - Download the source package, verify shasum and asc > > > > > > - Follow the README.md to build and run the Pulsar Node.js client. > > > > > > > > > The release candidate package has been published to the npm registry: > > > > > > > > > https://www.npmjs.com/package/pulsar-client/v/1.8.2-rc.2 > > > > > > > > > You can install it by `npm i pulsar-client@1.8.2-rc.2 > > > > > > --pulsar_binary_host_mirror= > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/` > > <https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/> > > > > > > and verify the package. > > > > > > > > > You can refer to this repository to verify tls related features: > > > > > > > > > https://github.com/shibd/pulsar-client-tls-test > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > Source files: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.2-rc.2/ > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > SHA-512 checksum: > > > > > > > > > > > > > > > 300cc86ab2fe0c433e818aa163f9646f7d23a6d26fd9dd8bcd61d375cfb69e9195eb4b13e37272f9c72a9e426a93f028c516e96546d60b0498f69bc4f9bb7276 > > > > > > ./apache-pulsar-client-node-1.8.2.tar.gz > > > > > > > > > The tag to be voted upon: > > > > > > v1.8.2-rc.2(c5fccfc) > > > > > > https://github.com/apache/pulsar-client-node/releases/tag/v1.8.2-rc.2 > > > > > > > > > Please review and vote on the release candidate #1 for the version > > > > > > 1.8.2, as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > > > Thanks, > > > > > > Baodi Shi > > > > > > > > > > > >
