Nice suggestion. I have change those parameters in the pip. It looks better now.
On 2023/05/15 13:21:06 PengHui Li wrote: > It looks good to me. > > Just a minor suggestion about the name of the configuration. > > managedLedgerInfoCompressionSizeThreshold -> > managedLedgerInfoCompressionThresholdInBytes > managedCursorInfoCompressionSizeThreshold > -> managedCursorInfoCompressionThresholdInBytes > > And is it better to introduce a minimum available value like 16KB > to avoid mistakes from the user? I don't think the compaction will > help much when the data is lower than 16KB. > > Thanks, > Penghui sorry, i will start the vote after the pip thoroughly discussed next time. > Hello lifepuzzlefun, > thanks for your proposal > I believe that it is too early to start a VOTE as the discussion has > not happened yet. yeah i will follow the community way to do it. but i think we need an agreement on this. there are two point on this: 1. the configuration is public api so any update to public api should be discussed. 2. make a fist way for those small pr that just configuration. > Side note: this change is small and it doesn't introduce breaking API > changes, I am not sure that we need a PIP for it.
