+1 Environment: macOS 10.13.4
* asc, sha1, sha512 are good for both src and binary distributions * binary distribution - run standalone - be able to produce and consume messages - run functions * src distribution - be able to compile and run same set of tests on compiled binary - there is no pre-compiled binaries in the src distributionOn Tue, May 15, 2018 at 4:32 PM Matteo Merli <matteo.me...@gmail.com> wrote: > Hi Dave, > the main problem in building the jar as part of build is that we need to > have the Jar built by Maven before the test of that module are executed, > though the Jar itself doesn't have to be in the classpath, otherwise the > test verification is not useful. The test itself was loading a jar and > verifying the class was loaded. > We have tried a few variations in Maven to get it working but with no luck, > so concluded it was better to move on for now without that test. Testing > the loading of the Jar is something that could probably be done more easily > as part of integration tests anyway. > Ivan has recently done a lot of work to include the integration testing > framework. We should be able to add some tests there to verify this > functionality. > Matteo > On Tue, May 15, 2018 at 4:21 PM Dave Fisher <dave2w...@comcast.net> wrote: > > Hi - > > > > Perhaps I missed the discussion about the Jar file. It looks like the > > decision was made to eliminate the test. > > > > I think that a better approach would be to actually compile it as part of > > the build. This would allow the test to also serve as a sort of “Hello > > World” for Pulsar functions. > > > > Is this the plan for 2.1? > > > > Regards, > > Dave > > > > > > > On May 14, 2018, at 4:33 PM, Matteo Merli <mme...@apache.org> wrote: > > > > > > This is the fourth release candidate for Apache Pulsar, version > > > 2.0.0-rc1-incubating. > > > > > > It fixes the following issues: > > > https://github.com/apache/incubator-pulsar/milestone/12?closed=1 > > > > > > *** Please download, test and vote on this release. This vote will stay > > open > > > for at least 72 hours *** > > > > > > Note that we are voting upon the source (tag), binaries are provided for > > > convenience. > > > > > > Source and binary files: > > > > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.0.0-rc1-incubating-candidate-4/ > > > > > > SHA-1 checksums: > > > a959a33500508d0ba690ca177eb39cf83dddf022 > > > apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz > > > 5b9bedd2f284c5a8d95ba6dc3c70af8c266fbb3b > > > apache-pulsar-2.0.0-rc1-incubating-src.tar.gz > > > > > > Maven staging repo: > > > https://repository.apache.org/content/repositories/orgapachepulsar-1014/ > > > > > > The tag to be voted upon: > > > v2.0.0-rc1-incubating-candidate-4 > > (e5d3bda9607703c2e012983c7ef64f5eb4118de7) > > > > > https://github.com/apache/incubator-pulsar/releases/tag/v2.0.0-rc1-incubating-candidate-4 > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > > > > > Please download the the source package, and follow the README to build > > > and run the Pulsar standalone service. > > > > > > -- > > > Matteo Merli > > > <mme...@apache.org> > > > > -- > Matteo Merli > <mme...@apache.org>