On Sun, May 20, 2018 at 5:32 PM Matteo Merli <matteo.me...@gmail.com> wrote:
> Willem, thanks for catching these issues. > > I have fixed the missing dependencies, specified the exact version of each > of them > and added a script to validate that new changes won't break it later. > https://github.com/apache/incubator-pulsar/pull/1820 > > I will cancel this vote and create a new candidate. > > Matteo > > On Sat, May 19, 2018 at 11:12 PM Willem Jiang <willem.ji...@gmail.com> > wrote: > >> Hi, >> >> As there are some License issues in the binary distribution (please check >> the section4 for more information), I had to vote -1 (binding). >> >> Here are the verifications which I did >> 1. check the checksums and verify the KEY. >> These KEY are not signed by the others, so I got the warning WARNING: >> This key is not certified with a trusted signature! >> >> 2. Checked the License and Notice file of the source distribution. >> It looks good. >> >> 3. Built the source with instruction of README and start the server >> It works and I can start the standalone server. >> I also checked the distribution file in the all directory, I can get the >> binary and source distribution there. >> >> 4. Checked the License and Notice file of the binary distribution. >> There is not version of bundled jars specified in the License file. It >> could cause some trouble as the License could be changed in different >> versions of jar distribution. >> >> Most of the bundled jars are specified in the License file, but some of >> them are missed. >> >> * com.google.errorprone-error_prone_annotations-2.0.19.jar >> >> * com.google.instrumentation-instrumentation-api-0.4.3.jar >> >> * com.squareup.okhttp-okhttp-2.5.0.jar >> >> * com.squareup.okio-okio-1.6.0.jar >> >> * org.apache.distributedlog-distributedlog-core-shaded-4.7.0.jar >> >> The javassist jar is not CDDL license, it has multiple licenses >> ASL,LGPL,MPL (we need to pick one of them). >> >> * org.javassist-javassist-3.21.0-GA.jar >> >> >> Willem Jiang >> >> >> On Fri, May 18, 2018 at 11:35 AM, Matteo Merli <mme...@apache.org> wrote: >> >> > This is the fourth release candidate for Apache Pulsar, version >> > 2.0.0-rc1-incubating. >> > >> > Pulsar is a highly scalable, low latency messaging platform running on >> > commodity hardware. >> > It provides simple pub-sub semantics over topics, guaranteed >> at-least-once >> > delivery of >> > messages, automatic cursor management for subscribers, and >> geo-replication. >> > >> > Link to the voting thread on pulsar dev list: >> > https://lists.apache.org/thread.html/865ac7e993265a31512642c5f29e53 >> > e65f4199b931a5ae91d07fba77@%3Cdev.pulsar.apache.org%3E >> > >> > It fixes the following issues: >> > https://github.com/apache/incubator-pulsar/milestone/12?closed=1 >> > >> > *** Please download, test and vote on this release. This vote will stay >> > open >> > for at least 72 hours *** >> > >> > Note that we are voting upon the source (tag), binaries are provided for >> > convenience. >> > >> > Source and binary files: >> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/ >> > pulsar-2.0.0-rc1-incubating-candidate-4/ >> > >> > SHA-1 checksums: >> > a959a33500508d0ba690ca177eb39cf83dddf022 >> > apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz >> > 5b9bedd2f284c5a8d95ba6dc3c70af8c266fbb3b >> > apache-pulsar-2.0.0-rc1-incubating-src.tar.gz >> > >> > Maven staging repo: >> > >> https://repository.apache.org/content/repositories/orgapachepulsar-1014/ >> > >> > The tag to be voted upon: >> > v2.0.0-rc1-incubating-candidate-4 (e5d3bda9607703c2e012983c7ef64f >> > 5eb4118de7) >> > https://github.com/apache/incubator-pulsar/releases/tag/ >> > v2.0.0-rc1-incubating-candidate-4 >> > >> > Pulsar's KEYS file containing PGP keys we use to sign the release: >> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS >> > >> > Please download the the source package, and follow the README to build >> > and run the Pulsar standalone service. >> > -- >> > Matteo Merli >> > <mme...@apache.org> >> > >> > -- > Matteo Merli > <mme...@apache.org> > -- Matteo Merli <mme...@apache.org>