2009/10/19 Aidan Skinner <[email protected]>: > On Mon, Oct 19, 2009 at 12:10 PM, <[email protected]> wrote: > >> Author: ritchiem >> Date: Mon Oct 19 11:10:33 2009 >> New Revision: 826638 >> >> URL: http://svn.apache.org/viewvc?rev=826638&view=rev >> Log: >> QPID-1816 : When client fails over due to an error, that error is still held >> bt the StateManager and will prvent the connection from working. During >> failover check and see if the Connection had been marked closed if so remove >> any set exception. > > Does this mean we can revert the try/catch in FailoverBaseCase.tearDown now?
Not sure what you mean here. My FBC.tearDown only has try/finally.. which needs to stay. If there is an unexpected error we still need to ensure we shutdown the secondary broker. I also don't think this is the complete solution. I don't have time right now to look at Ack failures, but they are much fewer than they were. I think that the remaining ones are due to other race conditions in the client close logic. I hope to have time soon to look at the issues. > - Aidan > -- > Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org > "A witty saying proves nothing" - Voltaire > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > > -- Martin Ritchie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
