2009/10/19 Aidan Skinner <[email protected]>: > On Mon, Oct 19, 2009 at 4:21 PM, Martin Ritchie <[email protected]> wrote: >> 2009/10/19 Aidan Skinner <[email protected]>: >>> On Mon, Oct 19, 2009 at 12:10 PM, <[email protected]> wrote: >>> >>>> Author: ritchiem >>>> Date: Mon Oct 19 11:10:33 2009 >>>> New Revision: 826638 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=826638&view=rev >>>> Log: >>>> QPID-1816 : When client fails over due to an error, that error is still >>>> held bt the StateManager and will prvent the connection from working. >>>> During failover check and see if the Connection had been marked closed if >>>> so remove any set exception. >>> >>> Does this mean we can revert the try/catch in FailoverBaseCase.tearDown now? >> >> Not sure what you mean here. My FBC.tearDown only has try/finally.. >> which needs to stay. If there is an unexpected error we still need to >> ensure we shutdown the secondary broker. > > Err, yeah, I actually meant SimpleACLTest (the change marnie made in > r825510), which catches JMSException on teardown, which I think this > change should make unnecessary.
Ah, right. That I don't know. The answer is perhaps, the test at least needs to be run without the catch to see if it works. I'm not 100% that the change will fix it as my change was aimed at connections that have failed over. The SACLT connections simply fail IIRC. So I don't think the fix I added gets executed. In the SACL test what needs to happen is that either the (io Thread performing) ConnectionCloseHandler OR the client thread calling close() needs to do the close... problem is both are. Martin > - Aidan > -- > Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org > "A witty saying proves nothing" - Voltaire > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > > -- Martin Ritchie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
