[
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851997#action_12851997
]
Rajith Attapattu commented on QPID-2418:
----------------------------------------
When investigating the test failure for "testResubscribeWithChangedSelector" in
the DurableSubscriptionTest, I was a bit shocked to see the amount of code
duplication.
This may have been due to a merge, but we definitely need to fix this. So thx
for taking care of this.
I haven't had chance to have a closer look at the patches, but please make sure
tests pass against both the C++ and Java Broker before committing it.
Also the change made in rev 929095 to the DurableSubscriptionTest.java (method
testResubscribeWithChangedSelector) is somehow passing for the Java broker.
Bcos we have the bug mentioned in this bug, it should be failing in both
brokers.
I am not so happy about checking in the change to the test case before a fix is
committed as this has broken our automated builds.
Perhaps the Java broker is creating a new queue as the arguments list is
different (the selector being different) ?
Isn't that a bug? Perhaps worthwhile investigating this.
> Existing durable subscription with selector is not unsubscribed during
> change to new subscription
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4, 0.5, 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2418-branch.patch, 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal)
> does not unsubscribe existing durable subscriptions. Whilst it does check for
> existing durable subscriptions in use by the client with the same name, it
> instead simply closes the subscriptions then creates a new one. As a result
> of not unsubscribing, the queue backing the subscription is not deleted
> before being used by the updated subscription as it should be (and as happens
> in the 0_8 and 0_10 subclasses when using durable subscriptions without
> selectors).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
