[ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852032#action_12852032
 ] 

Robbie Gemmell commented on QPID-2418:
--------------------------------------

The changes made to DurableSubscriptionTest were not intended to yet expose 
this bug any more than it was, and were deliberately kept short so that they 
wouldnt (the comment is innacurate youll note, as it isnt doing what it was 
originally and I forgot to update that). The new test added in 
DurableSubscriberTest that absolutely would expose it was excluded until it is 
fixed so that automated builds wouldnt be been broken. What I didnt do was run 
the test using the C++ broker as I didnt think I was changing anything of any 
particular note, but I failed to consider that it could behave slightly 
differently due to use of client side selectors rather than the server side 
selectors used by the Java broker. The broker doenst create a new queue, but it 
does change the filters used to select messages meaning that messges never get 
onto the queue which will on the C++ broker, which I imagine is where the test 
now fails. I'll take that into account when updating it.

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2418
>                 URL: https://issues.apache.org/jira/browse/QPID-2418
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M4, 0.5, 0.6
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.7
>
>         Attachments: 0001-QPID-2418-branch.patch, 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to