[
https://issues.apache.org/jira/browse/DISPATCH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462932#comment-17462932
] ASF GitHub Bot commented on DISPATCH-1403: ------------------------------------------ codecov-commenter edited a comment on pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465#issuecomment-996355314 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1465](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41716bd) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2af1a676b86cfaf0880cfbfc8b72305758f75d75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af1a67) will **decrease** coverage by `0.10%`. > The diff coverage is `76.30%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1465 +/- ## ========================================== - Coverage 84.76% 84.66% -0.11% ========================================== Files 116 117 +1 Lines 28623 28873 +250 ========================================== + Hits 24262 24445 +183 - Misses 4361 4428 +67 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/buffer\_field\_api.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2J1ZmZlcl9maWVsZF9hcGkuaA==) | `100.00% <100.00%> (ø)` | | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.30% <0.00%> (-1.08%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.18% <0.00%> (-0.56%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.95% <0.00%> (-0.20%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.16% <0.00%> (-0.19%)` | :arrow_down: | | [src/timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RpbWVyLmM=) | `96.87% <0.00%> (+0.02%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (+0.13%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2af1a67...41716bd](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consolidate chained qd_buffer_t field handling code > --------------------------------------------------- > > Key: DISPATCH-1403 > URL: https://issues.apache.org/jira/browse/DISPATCH-1403 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node > Affects Versions: 1.8.0, 1.9.0 > Reporter: Ken Giusti > Assignee: Ken Giusti > Priority: Minor > Labels: refactor > Fix For: Backlog > > > There are many places in the router's C codebase where we need to work with > data spanning a chained qd_buffer_t list. In particular the low level > operations such as: > * advance N bytes > * compare N bytes > * copy N bytes > are common throughout the code. > Here are examples from the iterator.c library: > [copy > bytes|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L378] > [advance > cursor|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L424] > [compare|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L467] > Similar logic is implemented in message.c and parse.c. > We should de-duplicate this code by providing a common implementation as part > of the buffer handling code. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
