[
https://issues.apache.org/jira/browse/DISPATCH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494230#comment-17494230
]
ASF subversion and git services commented on DISPATCH-1403:
-----------------------------------------------------------
Commit 87222386c1bb6f57eb7965c8a49f5a41002af8c4 in qpid-dispatch's branch
refs/heads/main from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8722238 ]
DISPATCH-1403: define a common buffer field API
Export the buffer data handling routines in the interator library as a
general API. Inlined for performance.
> Consolidate chained qd_buffer_t field handling code
> ---------------------------------------------------
>
> Key: DISPATCH-1403
> URL: https://issues.apache.org/jira/browse/DISPATCH-1403
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.8.0, 1.9.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Minor
> Labels: refactor
> Fix For: Backlog
>
>
> There are many places in the router's C codebase where we need to work with
> data spanning a chained qd_buffer_t list. In particular the low level
> operations such as:
> * advance N bytes
> * compare N bytes
> * copy N bytes
> are common throughout the code.
> Here are examples from the iterator.c library:
> [copy
> bytes|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L378]
> [advance
> cursor|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L424]
> [compare|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L467]
> Similar logic is implemented in message.c and parse.c.
> We should de-duplicate this code by providing a common implementation as part
> of the buffer handling code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
