[
https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481312#comment-17481312
]
ASF GitHub Bot commented on DISPATCH-2309:
------------------------------------------
kgiusti merged pull request #1493:
URL: https://github.com/apache/qpid-dispatch/pull/1493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Message body validation can succeed without validating the actual message body
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-2309
> URL: https://issues.apache.org/jira/browse/DISPATCH-2309
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.18.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.19.0
>
>
> See
> https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172
> and also this:
> [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206]
> The router should not be attempting to validate the body of a streaming
> message - it isn't possible to do this with confidence.
> The only time the router should be validating the entire body is for messages
> that are to be consumed by the router itself (subscriptions, router protocol,
> management, etc).
> Attempting to validate a streaming BODY via qd_message_check() should be
> treated as a programming error and assert().
> Protocol adaptors (which must validate body sections) should use the
> qd_message_stream_data api which will validate streaming body sections
> properly.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
