[ https://issues.apache.org/jira/browse/DISPATCH-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482660#comment-17482660 ]
ASF subversion and git services commented on DISPATCH-2309: ----------------------------------------------------------- Commit 0f03e24a6a3e25bc5e55fc0383c411e6c842fb87 in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0f03e24 ] DISPATCH-2309: Ensure rx message validation succeeds before forwarding o Determine the proper validation depth if message logging used o move message logging calls to point of forwarding o Include link-routed messages in validation o Fail if attempting to validate after streaming buffers freed o Extra Credit: add message rejection errors and remove dead code > Message body validation can succeed without validating the actual message body > ------------------------------------------------------------------------------ > > Key: DISPATCH-2309 > URL: https://issues.apache.org/jira/browse/DISPATCH-2309 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Affects Versions: 1.18.0 > Reporter: Ken Giusti > Assignee: Ken Giusti > Priority: Major > Fix For: 1.19.0 > > > See > https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2172 > and also this: > [https://github.com/apache/qpid-dispatch/blob/759aa173e440b139a7b6e05314e37b7f39d24d69/src/message.c#L2206] > The router should not be attempting to validate the body of a streaming > message - it isn't possible to do this with confidence. > The only time the router should be validating the entire body is for messages > that are to be consumed by the router itself (subscriptions, router protocol, > management, etc). > Attempting to validate a streaming BODY via qd_message_check() should be > treated as a programming error and assert(). > Protocol adaptors (which must validate body sections) should use the > qd_message_stream_data api which will validate streaming body sections > properly. > -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org