jiridanek commented on code in PR #6:
URL: https://github.com/apache/qpid-protonj2/pull/6#discussion_r1181081677
##########
protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientConnection.java:
##########
@@ -886,10 +886,11 @@ private void initializeProtonResources(ReconnectLocation
location) throws Client
protonConnection.setContainerId(connectionId);
}
+ final String hostname = (options.virtualHost() == null ||
options.virtualHost().length() < 1) ? location.getHost() :
options.virtualHost();
Review Comment:
nit: I'd go with `options.virtualHost().isEmpty()` for the second part of
the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
