tabish121 commented on PR #6: URL: https://github.com/apache/qpid-protonj2/pull/6#issuecomment-1530122280
There's a fair bit more to it than just setting the value as it needs to apply to both the Open and to the SASL init frames in the same way and we need a way to trigger a null host value which should be done similar to how it is done in Qpid JMS. This should be addressed by febc0aea5306a21bb65f388abb79c0950b5270d7 along with tests that are required for ensuring it remains fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org