[
https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836781#comment-17836781
]
ASF GitHub Bot commented on PROTON-2322:
----------------------------------------
jiridanek commented on code in PR #423:
URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563846762
##########
python/proton/_events.py:
##########
@@ -57,7 +57,6 @@ def more(self) -> bool:
return pn_collector_more(self._impl)
def pop(self) -> None:
- ev = self.peek()
Review Comment:
ah, never mind, there is one more statement below; so this was removed
because `ev` was unused and `self.peek()` only returns value without doing any
side-effects
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: PROTON-2322
> URL: https://issues.apache.org/jira/browse/PROTON-2322
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Assignee: Andrew Stitcher
> Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There
> are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
