[
https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836802#comment-17836802
]
ASF GitHub Bot commented on PROTON-2322:
----------------------------------------
jiridanek commented on code in PR #423:
URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563938118
##########
python/setup.cfg:
##########
@@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0
opentracing = opentracing; jaeger_client
[flake8]
-# TODO(PROTON-2322) decrease the limit
-max-line-length = 150
-
-# TODO(PROTON-2322) re-enable all these warnings
-ignore =
- # do not use bare 'except'
- E722,
- # imported but unused
- F401,
- # ambiguous variable name 'l'
- E741,
- # local variable 'int_nodes' is assigned to but never used
- F841,
- # TODO(PROTON-2322) decide which of these two warnings we want disabled
- # _transport.py:908:21: W503 line break before binary operator
- # _transport.py:907:56: W504 line break after binary operator
- W504,
Review Comment:
https://peps.python.org/pep-0008/#should-a-line-break-before-or-after-a-binary-operator
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: PROTON-2322
> URL: https://issues.apache.org/jira/browse/PROTON-2322
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Assignee: Andrew Stitcher
> Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There
> are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
