[
https://issues.apache.org/jira/browse/PROTON-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928439#comment-17928439
]
ASF GitHub Bot commented on PROTON-2531:
----------------------------------------
astitcher commented on PR #438:
URL: https://github.com/apache/qpid-proton/pull/438#issuecomment-2668837181
@pjfawcett Thanks for jogging my attention back here! I've been thinking
about this a little bit and I think I;'ve concluded that the surrogateescape
handling should actually be the default for conversions from binary to python
strings in the very few places we do it in both directions, mostly for
backwards compatibility to the previous swig binding.
So I'll take this PR and modify it slightly in that direction.
Thanks for your work on this.
If you want to create a separate PR to add a btag property to deliveries I'd
accept that - but currently I'm thinking that I'll change/fix this API when we
move to a 1.0 version to return a bytes object (this should be in the next 6-9
months).
> Delivery tag is str while it should be bytes
> --------------------------------------------
>
> Key: PROTON-2531
> URL: https://issues.apache.org/jira/browse/PROTON-2531
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Reporter: Ievgen Popovych
> Assignee: Pete Fawcett
> Priority: Major
>
> According to AMQP standard delivery tag is ??up to 32 octets of binary
> data??. Proton C library also has it in binary format.
> But in the Python binding {{Delivery.tag}} is a string, which causes issues
> when trying to use it (i.e. print/visualize).
> As far as I understand this is down to Swig {{python/cproton.i}}
> {{wrap_pn_delivery_tag}} (since typemap for {{pn_delivery_tag_t}} seems to be
> correct)?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
