[
https://issues.apache.org/jira/browse/QPID-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-3017:
-----------------------------
Attachment: 0003-QPID-3017-Added-unit-tests-for-new-LocalTransaction-.patch
0002-QPID-3017-Added-javadoc-and-logging.-Removed-todos.patch
0001-QPID-3017-Unit-tests-for-new-transaction-classes-in-.patch
I've attached a patch to address this task.
It covers:
1) Unit tests:
2) TODOs/javadoc
3) Refactored method name ServerTransaction.addPostCommitAction to
addPostTransactionAction to more accurately convey the purpose.
4) Error handling:
4a) LocalTransaction.java. There was a possibility of NullPointerException in
method tidyUpOnError() if _transaction was ever null. Code now guards against
this possibility.
4b) LocalTransaction.java: Methods dequeue() and enqueue() ignored the Action
(provided by the caller as formal parameter postTransactionAction) if an
Exception was thrown by the TransactionLog methds. Code now ensures
postTransactionAction is addedto the list _postTransactionAction in all cases.
4c) AutoCommitTransaction.java: There was a possibility of a transaction being
left in an open state. Code now guards against this possibility by aborting any
such transaction.
> Add unit tests and improve error handling for classes within
> org.apache.qpid.server.txn
> ---------------------------------------------------------------------------------------
>
> Key: QPID-3017
> URL: https://issues.apache.org/jira/browse/QPID-3017
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Affects Versions: Future
> Environment: N/A
> Reporter: Keith Wall
> Priority: Minor
> Attachments:
> 0001-QPID-3017-Unit-tests-for-new-transaction-classes-in-.patch,
> 0002-QPID-3017-Added-javadoc-and-logging.-Removed-todos.patch,
> 0003-QPID-3017-Added-unit-tests-for-new-LocalTransaction-.patch
>
>
> The following new transaction classes:
> org.apache.qpid.server.txn.LocalTransaction
> org.apache.qpid.server.txn.AutoCommitTransaction
> org.apache.qpid.server.txn.ServerTransaction
> added for 0-10 currently have no unit tests and there are several TODOs
> flagged in the error handling logic.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
