[ https://issues.apache.org/jira/browse/QPID-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031663#comment-13031663 ]
Rajith Attapattu commented on QPID-3207: ---------------------------------------- I think the best option is to rollback this change until we fix the deadlock. That will allow us to get the builds back on track. Meanwhile I will investigate the test failures to see if there is anything else affecting them other than the deadlock issue. > AMQSession.java close() does not close the consumers with the correct > arguments > ------------------------------------------------------------------------------- > > Key: QPID-3207 > URL: https://issues.apache.org/jira/browse/QPID-3207 > Project: Qpid > Issue Type: Bug > Components: Java Client > Affects Versions: 0.10 > Reporter: Rajith Attapattu > Assignee: Rajith Attapattu > Fix For: 0.11 > > > When the AMQSession.java close() is invoked it will in turn call the "private > void closeConsumers(Throwable error) throws JMSException" method. > In this method if the error is null then the consumer.close method is called > with "sendClose=false". > I wonder if this is the correct setting. I suspect the intended value is > "true". > The boolean value is used in determining if we should send a message-cancel > or not. > I am not sure why we are not going to send a message cancel in this case, as > we haven't encountered a session error and the session is active. > Note the AMQSession.java closes the session only after the consumers and > producers are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org