[
https://issues.apache.org/jira/browse/QPID-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031669#comment-13031669
]
Rajith Attapattu commented on QPID-3207:
----------------------------------------
I have reversed the commit, all though we need to restore it at some point once
we get through this deadlock issue.
IMO the original commit is the correct behaviour, so it would be interesting to
see what other issues have popped up in addition to the deadlock problem.
> AMQSession.java close() does not close the consumers with the correct
> arguments
> -------------------------------------------------------------------------------
>
> Key: QPID-3207
> URL: https://issues.apache.org/jira/browse/QPID-3207
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: 0.11
>
>
> When the AMQSession.java close() is invoked it will in turn call the "private
> void closeConsumers(Throwable error) throws JMSException" method.
> In this method if the error is null then the consumer.close method is called
> with "sendClose=false".
> I wonder if this is the correct setting. I suspect the intended value is
> "true".
> The boolean value is used in determining if we should send a message-cancel
> or not.
> I am not sure why we are not going to send a message cancel in this case, as
> we haven't encountered a session error and the session is active.
> Note the AMQSession.java closes the session only after the consumers and
> producers are closed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
