[ 
https://issues.apache.org/jira/browse/QPID-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050937#comment-13050937
 ] 

Robbie Gemmell commented on QPID-3273:
--------------------------------------

I think the enum should be static since it makes no use of the containing 
class, and probably private too (if it warrants being public then in this case 
it should be in its own file rather than being duplicated).

Also, it occurs to me that there cant be an existing test for this otherwise 
the patch would be breaking it, so I think adding a unit test to cover the 
change is in order.

>  JMSDeliveryMode has to be used as a string in a selector
> ---------------------------------------------------------
>
>                 Key: QPID-3273
>                 URL: https://issues.apache.org/jira/browse/QPID-3273
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>            Priority: Minor
>             Fix For: 0.11
>
>         Attachments: 0001-QPID-3273.patch
>
>
> Section 3.8.13 of the JMS spec says that JMSDeliveryMode has to be used as a 
> string in a selector (i.e. JMSDeliveryMode = 'PERSISTENT'). 
> But Qpid only supports it as an integer (i.e JMSDeliveryMode = 2).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to