[
https://issues.apache.org/jira/browse/QPID-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051176#comment-13051176
]
Rajith Attapattu commented on QPID-3273:
----------------------------------------
I will make it private. It would have been nice if there was a way to not
duplicate it in both classes, but I think such a change was out of scope.
Perhaps this is something we should keep in mind when we redesign things.
As for the tests, I will try to add it to an existing test case.
I don't think adding a new test case for each commit is a very useful thing
(this is not a criticism of your statement, but rather an observation of how we
deal with this as a project). We currently have a very bloated test suite that
is becoming unmanageable. However that's topic we need to discuss on a separate
forum :)
> JMSDeliveryMode has to be used as a string in a selector
> ---------------------------------------------------------
>
> Key: QPID-3273
> URL: https://issues.apache.org/jira/browse/QPID-3273
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.8, 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.11
>
> Attachments: 0001-QPID-3273.patch
>
>
> Section 3.8.13 of the JMS spec says that JMSDeliveryMode has to be used as a
> string in a selector (i.e. JMSDeliveryMode = 'PERSISTENT').
> But Qpid only supports it as an integer (i.e JMSDeliveryMode = 2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
