----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7412/ -----------------------------------------------------------
(Updated Oct. 6, 2012, 4:39 p.m.)
Review request for qpid, Robbie Gemmell, Weston Price, and Keith Wall.
Description
-------
The attached patch does the following,
1. Node bindings are created when the node is created (was there before).
2. Node bindings are deleted when the node is deleted (added in this patch).
3. Link bindings are created when a subscription or producer is created (was
there before)
4. Link bindings are deleted when a subscription or producer is closed (added
in this patch).
The code was modified to treat node and link bindings separately.
This addresses bug QPID-3317.
https://issues.apache.org/jira/browse/QPID-3317
Diffs (updated)
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQDestination.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_8.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQTopic.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_8.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/AddressHelper.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/Link.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/Node.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client/destination/AddressBasedDestinationTest.java
1394702
Diff: https://reviews.apache.org/r/7412/diff/
Testing
-------
Used the existing AddressBasedDestinationTest to verify the new work.
Currently looking at adding unit tests to cover the code. Will update the patch
with this.
Thanks,
rajith attapattu
