-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7412/
-----------------------------------------------------------
(Updated Oct. 6, 2012, 4:55 p.m.)
Review request for qpid, Robbie Gemmell, Weston Price, and Keith Wall.
Description (updated)
-------
The attached patch does the following,
1. Node bindings are created when the node is created (was there before).
2. Node bindings are deleted when the node is deleted (added in this patch).
3. Link bindings are created when a subscription or producer is created (was
there before)
4. Link bindings are deleted when a subscription or producer is closed (added
in this patch).
The code was modified to treat node and link bindings separately.
I have also added sync() methods (disregarding the nowait flag) when creating a
producer or consumer to ensure we report the errors correctly.
(In the existing code, When creating consumers the nowait flag was set to
false, while when creating durable subscribers it was set to true.).
Please ignore the white space errors. The git based patch I have is free of
them.
I had to create an svn diff as rb doesn't accept the git patch.
This addresses bug QPID-3317.
https://issues.apache.org/jira/browse/QPID-3317
Diffs
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQDestination.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_8.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQTopic.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_8.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/AddressHelper.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/Link.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/Node.java
1394702
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client/destination/AddressBasedDestinationTest.java
1394702
Diff: https://reviews.apache.org/r/7412/diff/
Testing (updated)
-------
Used the existing AddressBasedDestinationTest to verify the new work does not
break any functionality.
Added an explicit test case for verifying link beahvior as well as customizing
the subscription queue.
Added unit tests for AddressHelper.
Thanks,
rajith attapattu
