----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8331/#review14292 -----------------------------------------------------------
/proton/trunk/proton-c/include/proton/ssl.h <https://reviews.apache.org/r/8331/#comment30444> What happens if you call this twice for the same transport or the same domain/transport pair? /proton/trunk/proton-c/include/proton/ssl.h <https://reviews.apache.org/r/8331/#comment30445> Do we need to deprecate this? Could we not simply make init take a domain and session-id? - Rafael Schloming On Dec. 10, 2012, 7:56 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8331/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 7:56 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Description > ------- > > Support for client-driven SSL session resumption. More testing is needed, > but the API changes are pretty extensive so I wanted to get some wider > visibility sooner rather than later. > > I'll provide in-code API documentation before I check in, but for now you can > reference the original JIRA for the background. > > > This addresses bug PROTON-136. > https://issues.apache.org/jira/browse/PROTON-136 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1419706 > /proton/trunk/proton-c/include/proton/ssl.h 1419706 > /proton/trunk/proton-c/src/ssl/openssl.c 1419706 > /proton/trunk/proton-c/src/ssl/ssl_stub.c 1419706 > /proton/trunk/tests/proton_tests/ssl.py 1419706 > > Diff: https://reviews.apache.org/r/8331/diff/ > > > Testing > ------- > > Original unit tests pass, added two more specific to these changes. No 3rd > party interopt testing yet. > > > Thanks, > > Kenneth Giusti > >
