----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8331/#review14669 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Dec. 18, 2012, 4:27 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8331/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 4:27 p.m.) > > > Review request for qpid, Ted Ross, Keith Wall, Rafael Schloming, and Philip > Harvey. > > > Description > ------- > > Support for client-driven SSL session resumption. More testing is needed, > but the API changes are pretty extensive so I wanted to get some wider > visibility sooner rather than later. > > I'll provide in-code API documentation before I check in, but for now you can > reference the original JIRA for the background. > > > This addresses bug PROTON-136. > https://issues.apache.org/jira/browse/PROTON-136 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1423515 > /proton/trunk/proton-c/include/proton/ssl.h 1423515 > /proton/trunk/proton-c/src/messenger.c 1423515 > /proton/trunk/proton-c/src/ssl/openssl.c 1423515 > /proton/trunk/proton-c/src/ssl/ssl_stub.c 1423515 > > /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Ssl.java > 1423515 > > /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/SslDomain.java > PRE-CREATION > > /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/SslPeerDetails.java > PRE-CREATION > > /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Transport.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/DefaultSslEngineFacade.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/ProtonSslEngine.java > PRE-CREATION > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/ProtonSslEngineProvider.java > PRE-CREATION > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SimpleSslTransportWrapper.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslDomainImpl.java > PRE-CREATION > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslEngineFacade.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslEngineFacadeFactory.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslImpl.java > 1423515 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslPeerDetailsImpl.java > PRE-CREATION > /proton/trunk/proton-j/proton/src/main/scripts/proton.py 1423515 > > /proton/trunk/proton-j/proton/src/test/java/org/apache/qpid/proton/engine/impl/ssl/CapitalisingDummySslEngine.java > 1423515 > > /proton/trunk/proton-j/proton/src/test/java/org/apache/qpid/proton/engine/impl/ssl/SimpleSslTransportWrapperTest.java > 1423515 > /proton/trunk/tests/proton_tests/ssl.py 1423515 > > Diff: https://reviews.apache.org/r/8331/diff/ > > > Testing > ------- > > Original unit tests pass, added two more specific to these changes. No 3rd > party interopt testing yet. > > > Thanks, > > Kenneth Giusti > >
