----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36546/ -----------------------------------------------------------
(Updated July 17, 2015, 9:09 a.m.) Review request for qpid, Andrew Stitcher and Rafael Schloming. Changes ------- prepend AMQP to spec-mandated default constants. (I meant to do this before.) The names are as long as they need to be for clarity. Repository: qpid-proton-git Description ------- PROTON-930: extract numeric default values from AMQP xml at build-time. Diffs (updated) ----- proton-c/src/protocol.h.py bbc0dfe proton-c/src/transport/transport.c 7bce3b5 Diff: https://reviews.apache.org/r/36546/diff/ Testing (updated) ------- build ctest -VV This code creates the following new code near the top of protocol.h /* Numeric default values */ #define AMQP_OPEN_MAX_FRAME_SIZE_DEFAULT 4294967295 #define AMQP_OPEN_CHANNEL_MAX_DEFAULT 65535 #define AMQP_BEGIN_HANDLE_MAX_DEFAULT 4294967295 #define AMQP_SOURCE_TIMEOUT_DEFAULT 0 #define AMQP_TARGET_TIMEOUT_DEFAULT 0 Thanks, michael goulish
